Use make_shared in pricing engines#2636
Merged
lballabio merged 3 commits intoJul 20, 2026
Merged
Conversation
|
coverage: 74.936% (+0.09%) from 74.843% — jewonj0620:feature/use-make-shared-pricingengines into lballabio:master |
Owner
|
As we're going through this modernization, I think it's fair to use |
Contributor
Author
|
Okay. Sounds good to me. I will proceed to use auto instead of alias in declaration. I will apply the patch for this from this pr Hope the review is not confused. will notify after the update! |
Contributor
Author
|
@lballabio sorry for being late. apply auto declaration for changes please feel free to leave a comment! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces old-style
ext::shared_ptr<T>(new ...)constructions withext::make_shared<T>(...)underql/pricingengines.The change is intended as a mechanical modernization and follows the existing
ext::make_sharedusage in the codebase.In addition, added some auto declaration when rhs and lhs return types are identical